Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linkify addon to demo #90

Closed
wants to merge 1 commit into from
Closed

Add linkify addon to demo #90

wants to merge 1 commit into from

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 8, 2016

No description provided.

@parisk
Copy link
Contributor

parisk commented Jun 8, 2016

The linkify addon has some major issues right now (#27, #24) which should be fixed before adding it to the demo.

Will try to deal with linkify, after dealing with CJK characters.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 10, 2016

I wouldn't consider #24 a blocker though, seems like a harmless limitation. It would be a great enhancement to support only single-line URLs imo. #27 and #96 block adoption in vscode from what I can see so far.

@parisk
Copy link
Contributor

parisk commented Jun 13, 2016

#27 is the big blocker actually. I hope that I will be able to deal with this, along with #96 (comment) within tomorrow.

@parisk parisk added the on-hold label Jun 15, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 23, 2016

Closing this off, it's trivial to do if we want.

@Tyriar Tyriar closed this Jun 23, 2016
@Tyriar Tyriar deleted the add_linkify_to_demo branch February 3, 2017 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk