Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SONiC Versions #46

Open
wants to merge 1 commit into
base: fix-seperator-202012-1
Choose a base branch
from

Conversation

mssonicbld
Copy link
Collaborator

Upgrade SONiC Versions

@mssonicbld mssonicbld force-pushed the repd/versions/fix-seperator-202012-1 branch from db7704a to df10e1a Compare March 10, 2023 10:10
@xumia xumia force-pushed the fix-seperator-202012-1 branch 2 times, most recently from bceb1ca to 85c68f5 Compare March 10, 2023 14:45
@mssonicbld mssonicbld force-pushed the repd/versions/fix-seperator-202012-1 branch from df10e1a to 9c80e31 Compare March 10, 2023 19:07
@xumia xumia force-pushed the fix-seperator-202012-1 branch 3 times, most recently from e0f3063 to 438a152 Compare March 11, 2023 03:03
@mssonicbld mssonicbld force-pushed the repd/versions/fix-seperator-202012-1 branch from 9c80e31 to eb95b0f Compare March 11, 2023 07:05
@mssonicbld mssonicbld force-pushed the repd/versions/fix-seperator-202012-1 branch from eb95b0f to 97fa4be Compare March 11, 2023 16:55
xumia pushed a commit that referenced this pull request Mar 20, 2023
…cause file removal issue (sonic-host-services #46) (sonic-net#14106)

Why I did it
Porting/cherry-pick PR sonic-net/sonic-host-services#46
"show reboot-cause history" shows empty history. When the previous-reboot-cause has a broken symlink, And rebooting the system will not be able to generate a new symlink of the new previous-reboot-cause.

admin@sonic:~$ show reboot-cause history 
Name    Cause    Time    User    Comment
------  -------  ------  ------  ---------
How I did it
Somehow, when the symlink file /host/reboot-cause/previous-reboot-cause is broken (which its destination files doesn't exist in this case), the current condition check "if os.path,exists(PREVIOUS_REBOOT_CAUSE_FILE)" will return False in determine-reboot-cause script. Hence, the current previous-reboot-cause is not been removed and the recreation of the new previous-reboot-cause failed. In case of previous-reboot-cause is a broken synlink file, add condition os.path.islink(PREVIOUS_REBOOT_CAUSE) to check and allow the remove operation happens.

How to verify it
Manually make the /host/reboot-cause/previous-reboot-cause to be a broken symlink file by removing its destination file
reboot the system. "show reboot-cause history" should show the correct info

Signed-off-by: mlok <marty.lok@nokia.com>
xumia pushed a commit that referenced this pull request Feb 7, 2024
…ly (sonic-net#18046)

#### Why I did it
src/dhcprelay
```
* 363fa06 - (HEAD -> master, origin/master, origin/HEAD) Skip vlans with no dhcpv6 server configured (#46) (8 hours ago) [kellyyeh]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant