Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the node is up before trying to use it. #32

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Make sure the node is up before trying to use it. #32

merged 4 commits into from
Aug 26, 2020

Conversation

tedsteen
Copy link
Contributor

Related to #31

@xunleii
Copy link
Owner

xunleii commented Aug 25, 2020

Thanks for your issue and for this PR. I will fix the CI first, sorry for the inconvenience.

@xunleii
Copy link
Owner

xunleii commented Aug 25, 2020 •
edited
Loading

I don't know why the CI fails (works here), but the terraform fmt step failed (https://github.com/xunleii/terraform-module-k3s/pull/32/checks?check_run_id=1027925789#step:5:10). Can you run terraform fmt ?

Thanks a lot for your help !

@tedsteen
Copy link
Contributor Author

tedsteen commented Aug 26, 2020 •
edited
Loading

Can you run terraform fmt ?

Done!

@xunleii xunleii merged commit c50c5ef into xunleii:master Aug 26, 2020
@xunleii
Copy link
Owner

xunleii commented Aug 26, 2020

Thanks ! I will release a new version of this module today

@xunleii xunleii linked an issue Aug 26, 2020 that may be closed by this pull request
NodeNotFound when trying to update nodes #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeNotFound when trying to update nodes
2 participants
@tedsteen @xunleii