Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing 'Hetzner example' docs #51

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Enhancing 'Hetzner example' docs #51

merged 4 commits into from
Apr 28, 2021

Conversation

NicoWde
Copy link
Contributor

@NicoWde NicoWde commented Apr 2, 2021

after running into the same issue as #50, I hoped this would help :)

Any feedback is appreciated!

@xunleii
Copy link
Owner

xunleii commented Apr 18, 2021

Hi @NicoWde, sorry for the 2 weeks off non response, I had many things to do.
Thanks a lot for your help, I will try to read it this week.

Copy link
Owner

@xunleii xunleii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedsteen what do you think about this PR ?

@tedsteen
Copy link
Contributor

@tedsteen what do you think about this PR ?

I think it's fine! I'd personally skip the example (I think it's mostly noise when you want to focus on k3s terraforming) but I totally see you point with copy/pase. You're the owner so you're the boss :)

@xunleii
Copy link
Owner

xunleii commented Apr 28, 2021

I think it's mostly noise when you want to focus on k3s terraforming

I also see your point and I agree with you. I will move this example in the Wiki (in the future) to keep both readability and accuracy.

You're the owner so you're the boss :)

You're the end user, you're much more important than the boss ;)

@NicoWde @tedsteen thanks a lot for your work, I really appreciate :)

@xunleii xunleii merged commit d7952a2 into xunleii:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants