Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix civo example #55

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix civo example #55

merged 2 commits into from
Oct 6, 2021

Conversation

debovema
Copy link
Contributor

Wanted to test the civo example and I had to do the following modifications to make it work.

@xunleii
Copy link
Owner

xunleii commented Aug 25, 2021

Thanks a lot for your contribution @debovema. I always forgot that we have a CIVO example 😅

@xunleii
Copy link
Owner

xunleii commented Aug 25, 2021

Is it possible to amend your commit in order to use the conventional commit format ?

Otherwise, LGTM

@debovema
Copy link
Contributor Author

Thanks a lot for your contribution @debovema. I always forgot that we have a CIVO example 😅

I didn't know about this provider and was curious to make a try.

Interested in adding a Scaleway example ? I would be happy to contribute.

Is it possible to amend your commit in order to use the conventional commit format ?

Otherwise, LGTM

Done

@xunleii
Copy link
Owner

xunleii commented Oct 5, 2021

Hi @debovema, sorry, I totally forgot your PR. I upgraded many things that breaks your PR and I'm sorry for that. Could you rebase it ?

Interested in adding a Scaleway example ? I would be happy to contribute.

Of course, I will be happy too to see more contribution and more examples for the community ! (I can create a issue about that for Hacktoberfest if you want :) )

@debovema
Copy link
Contributor Author

debovema commented Oct 6, 2021

Done

@xunleii
Copy link
Owner

xunleii commented Oct 6, 2021

You're awesome ! Thanks for your reactivity !

I'll remove the .terraform.lock.hcl on the example (not a good practice, I know) to allow CI to check if the latest valid plugin version works.

NOTE: ... and also because the CI fails

I remove this file waiting a fix on the GA workflow
@xunleii xunleii merged commit 63351fb into xunleii:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants