Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Android support #99

Merged
merged 14 commits into from
Nov 16, 2024
Merged

Adding Android support #99

merged 14 commits into from
Nov 16, 2024

Conversation

LikeTheSalad
Copy link
Contributor

Solves #8

@xvik
Copy link
Owner

xvik commented Nov 15, 2024

Thank you very much!
I just need one more thing: a sample android project. The main problem is that i'm not developing android apps (and never did) so I need a usage example to add it as a test case (to make sure it works and to catch regressions later).

It might be a complete android project in examples dir or, at least, please post an example gradle script (as comment here) and a sample application source (the simplest hello word).

@xvik
Copy link
Owner

xvik commented Nov 15, 2024

By the way, why android lib project support is enough? What if user use android application plugin? (maybe it is always used together with the library plugin)

@LikeTheSalad
Copy link
Contributor Author

Thank you for your feedback! I'll add a sample project for tests 👍

By the way, why android lib project support is enough? What if user use android application plugin? (maybe it is always used together with the library plugin)

Tbh it's mostly because I was focusing on the use case of Android apis availability, for which I have a problem right now because the "native mechanism" provided for Android libs is forcing consumer projects (android apps) to do some setup that's not needed in some cases, so that's why I was focusing on "well-behaved libraries" essentially, given that an android app will always be the last build (no other android project can "consume" an app), people could just use the "native mechanism" for apps without worrying about affecting anybody else. However, I didn't think of other use cases, maybe not necessarily related to Android apis availability, so I think it's fine to also add support for apps, it should be the same process too so I'll just add it to this PR.

@LikeTheSalad
Copy link
Contributor Author

Hi @xvik - I've added support for android apps and also some examples, please have another look when you get a chance!

@xvik
Copy link
Owner

xvik commented Nov 15, 2024

Thank you very much!

@xvik xvik merged commit 6674794 into xvik:master Nov 16, 2024
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants