Fix rounding-off error on progress calculation (#346)

I fix a blinking issue when change lottie progress. The duration of compositon has offset in LottieCompositionParser (parameters.endFrame = reader.nextDouble() - 0.01), but progress calculate is based on the original value(no-offset), the function roundProgress() will caculate a error progress. The issue is same as: airbnb/lottie-android#1372. --------- Co-authored-by: Xavier Hainaux <xavier.hainaux@gmail.com>
xvrh · May 12, 2024 · 3c58936 · 3c58936
1 parent d0fed17
commit 3c58936
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 1 deletion.
diff --git a/lib/src/composition.dart b/lib/src/composition.dart
@@ -225,7 +225,8 @@ class LottieComposition {
     fps ??= frameRate.framesPerSecond;
     assert(!fps.isNaN && fps.isFinite && !fps.isNegative);
 
-    var totalFrameCount = seconds * fps;
+    var noOffsetDurationFrames = durationFrames + 0.01;
+    var totalFrameCount = (noOffsetDurationFrames / this.frameRate) * fps;
     var frameIndex = (totalFrameCount * progress).toInt();
     var roundedProgress = frameIndex / totalFrameCount;
     assert(roundedProgress >= 0 && roundedProgress <= 1,

diff --git a/test/golden/Logo/LogoSmall_0_5.png b/test/golden/Logo/LogoSmall_0_5.png
diff --git a/test/golden/Mobilo/A_0_5.png b/test/golden/Mobilo/A_0_5.png
diff --git a/test/golden/Mobilo/B_0_5.png b/test/golden/Mobilo/B_0_5.png
diff --git a/test/goldens/dynamic/opacity_interpolation_05.png b/test/goldens/dynamic/opacity_interpolation_05.png
diff --git a/test/goldens/dynamic/opacity_interpolation_10.png b/test/goldens/dynamic/opacity_interpolation_10.png
diff --git a/test/goldens/dynamic/time_remapping.png b/test/goldens/dynamic/time_remapping.png
diff --git a/test/goldens/enable_render_cache.png b/test/goldens/enable_render_cache.png
diff --git a/test/goldens/opacity_layers.png b/test/goldens/opacity_layers.png