XWIKI-22581: FocusCatcher input has no label #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced the FocusCatcher artificial input with a semantically better span. * Updated the style of the gallery to use css grid instead of hackish solutions all around. * Improved accessibility by changing the div interactive controllers with buttons. TODO: Check further the half screen large picture maximized gallery behavior bug and find a fix for it.
* Fixed the full screen display vertical overflow issue.
* Fixed a typo
mflorea
requested changes
Dec 9, 2024
...eb/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css
Outdated
Show resolved
Hide resolved
...eb/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css
Outdated
Show resolved
Hide resolved
...eb/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
39
| /* Instead of an arbitrary element to catch focus, we use the index. | ||
| * This index already stores the current image state, might as well be responsible for providing quick controls and | ||
| * explanations about these quick controls. | ||
| * Note that wrapping the image in an interactive container to handle this would have been a good solution too. | ||
| * However, this wrapping caused the image to overflow the CSS grid vertically when in maximized mode. | ||
| * Technically I couldn't find a CSS solution to prevent this, so I decided to make do without wrapping. */ |
There was a problem hiding this comment.
Suggested change
| /* Instead of an arbitrary element to catch focus, we use the index. | |
| * This index already stores the current image state, might as well be responsible for providing quick controls and | |
| * explanations about these quick controls. | |
| * Note that wrapping the image in an interactive container to handle this would have been a good solution too. | |
| * However, this wrapping caused the image to overflow the CSS grid vertically when in maximized mode. | |
| * Technically I couldn't find a CSS solution to prevent this, so I decided to make do without wrapping. */ | |
| // Instead of an arbitrary element to catch focus, we use the index. | |
| // This index already stores the current image state, might as well be responsible for providing quick controls and | |
| // explanations about these quick controls. | |
| // Note that wrapping the image in an interactive container to handle this would have been a good solution too. | |
| // However, this wrapping caused the image to overflow the CSS grid vertically when in maximized mode. | |
| // Technically I couldn't find a CSS solution to prevent this, so I decided to make do without wrapping. |
Multiline comments are normally used to document functions (methods) and classes (or types in general).
There was a problem hiding this comment.
We don't have a code style for javascript AFAIR. I assumed it'd be best to use the same comment style as the one we use for CSS. It would be interesting to keep trace of this rule so that new contributors won't make the same mistake. I created the draft doc https://dev.xwiki.org/xwiki/bin/view/Drafts/Javascript%20Code%20Style/ for now.
Reference of where we can already see this codestyle in action
There was a problem hiding this comment.
I assumed it'd be best to use the same comment style as the one we use for CSS.
JavaScript is a programming language, unlike CSS, so I don't think it makes sense to look at CSS code styles for defaults. The default should be the Java code style IMO.
* Comment formatting Co-authored-by: Marius Dumitru Florea <marius@xwiki.com>
|
The comments on this PR are addressed and it is ready for further review or a merge. |
mflorea
approved these changes
Dec 10, 2024
mflorea
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Replaced the FocusCatcher artificial input with a semantically better span. * Updated the style of the gallery to use css grid instead of hackish solutions all around. * Improved accessibility by changing the div interactive controllers with buttons. * Fixed the full screen display vertical overflow issue. (cherry picked from commit 4241c3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22581
Changes
Description
Clarifications
Screenshots & Video
Video demo:
2024-10-18.13-54-58.mp4
The gallery controls are tested both with the mouse and the keyboard.
Before:
After:
I tried to keep the visuals as close as possible as what was here before. The only differences I can spot are:
previous/nextbuttons. This happens because of the default padding that was added when transforming this element in a button. IMO this change is not a problem.Executed Tests
Manual tests: see above + tests with different screen sizes.
Built changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Pqualityand testedmvn clean install -f xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-test/xwiki-platform-office-test-docker -Pdocker -Dxwiki.test.ui.wcag=true. The WCAG violations reported did not highlight any issue with the gallery anymore.Expected merging strategy