XWIKI-22813: Create User dialog no longer automatically suggests username based on first and last names #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name based on first and last names * Added a parameter in the registration class. * Added the API to retrieve this parameter * Used this API in the velocity template for the form. * Deprecated the `About You` section title and reorganized the form to take into account the discussion. WIP: atm, setting the parameter to true does not make the fields appear...
…name based on first and last names * Added the script service associated to the new API.
…name based on first and last names * Fixed the form error that prevented the form from being submitted by admins when in a dialog. * Updated documentation to reflect the new state of the form.
…name based on first and last names * Updated translations to provide a correct description of the admin parameter added.
…name based on first and last names * Fixed the changes to the registration form template
|
Discussed on the live chat: the removal of the first and last name fields should be discussed more and not backported to LTS without careful consideration. We won't be merging this PR in 16.10.4 in order to have more time to discuss some changes. Opening this PR back up for reviews when we have agreed on:
|
|
The conclusion reached is that we should revert the changes to the form to keep only the version with first and last name. A switch for that is superfluous and it's not worth the complexity in the Admin UI. |
…name based on first and last names * Reverted the addition of a toggle for the state of the form. Reverted the form field order to what used to be.
…name based on first and last names * Reverted the addition of a toggle for the state of the form. Reverted misc leftover changes
…name based on first and last names * Reverted the addition of a toggle for the state of the form. Reverted misc leftover changes
|
Done in the past three commits. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22813
Changes
Description
About Yousection title and reorganized the form to take into account the discussion.Clarifications
User and rights -> Registrationsection. Checking this box will make the form very similar to what used to be before the changes brought in XWIKI-22121.Screenshots & Video
Video demo of the changes, with the toggle ON and OFF:
2025-02-18.15-38-06.mp4
I'm not 200% sure about the position in the Admin form, we can still move it later if needed.
At the time of the video, I forgot to add the parameter hint. Here is what it looks like after the last commit:
Executed Tests
Manual tests, see above.
Passed successfully
mvn clean install -f xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication -Pquality,docker,integration-testsin three minutes (2 minutes in the docker tests).Initial self proofreading done.
Expected merging strategy