XCOMMONS-3321: Upgrade to Jackson 2.19.0 #4152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
commented
May 12, 2025
| @@ -323,7 +323,8 @@ private DisplayerDescriptor getDisplayerConfig(String column, ObjectNode columnP | |||
| DisplayerDescriptor displayerConfig = new DisplayerDescriptor(); | |||
| if (columnProperties.path(ACTIONS).isArray()) { | |||
| displayerConfig.setId(ACTIONS); | |||
| displayerConfig.setParameter(ACTIONS, columnProperties.get(ACTIONS)); | |||
| displayerConfig.setParameter(ACTIONS, | |||
| columnProperties.get(ACTIONS).valueStream().map(JsonNode::asText).toList()); | |||
There was a problem hiding this comment.
Pointing out that I had to replace arrays with list to values comparable with what is in the test.
tmortagne
reviewed
May 12, 2025
|
|
||
| LiveDataEntryDescriptor that = (LiveDataEntryDescriptor) o; | ||
|
|
||
| return new EqualsBuilder() |
There was a problem hiding this comment.
Not sure it worth creating a EqualsBuilder for a single property. Objects.equals should do fine.
There was a problem hiding this comment.
This special case is not documented on https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HEquals2FHashCodeandToStringimplementations, so I aimed for code consistency.
tmortagne
reviewed
May 12, 2025
|
|
||
| LiveDataSelectionConfiguration that = (LiveDataSelectionConfiguration) o; | ||
|
|
||
| return new EqualsBuilder() |
There was a problem hiding this comment.
Not sure it worth creating a EqualsBuilder for a single property. Objects.equals should do fine.
tmortagne
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
All of the tests of the live data module.
Expected merging strategy