Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for web vitals ratio upto 0.001. #96

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Add support for web vitals ratio upto 0.001. #96

merged 3 commits into from
Mar 6, 2023

Conversation

bharatpareek
Copy link
Contributor

@bharatpareek bharatpareek commented Feb 23, 2023 •
edited
Loading

Fixes #
Added support for adding web vitals tracking ratio as low as 0.001.
Issue 80

Tasks

  • Added support for adding tracking ratio as low as 0.001.
  • Updated PHP tests.

Describe the Approach

  • I updated the min value and step param in the input field to accept values as low as 0.001 and increment with steps of 0.001.

Tonnie-Exelero
Tonnie-Exelero approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@Tonnie-Exelero Tonnie-Exelero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the great work @bharatpareek

@bharatpareek bharatpareek merged commit db1e669 into master Mar 6, 2023
@bharatpareek bharatpareek deleted the fix/80-allow-smaller-tracking-ratio branch March 6, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonnie-Exelero Tonnie-Exelero Tonnie-Exelero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharatpareek @Tonnie-Exelero