Skip to content

Commit

Permalink
Don't automagically hide the Connector in the context column
Browse files Browse the repository at this point in the history
  • Loading branch information
@frankiejarrett
frankiejarrett committed May 20, 2014
1 parent 1e56427 commit 539d24f
Showing 1 changed file with 9 additions and 20 deletions.
29 changes: 9 additions & 20 deletions includes/list-table.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -224,26 +224,15 @@ function column_default( $item, $column_name ) {
$connector_title = $this->get_term_title( $item->{'connector'}, 'connector' );
$context_title = $this->get_term_title( $item->{'context'}, 'context' );

// If the Connector and Context titles loosely match then only display the Context
if ( $connector_title == $context_title ) {
$out = $this->column_link(
$context_title,
array(
'connector' => $item->{'connector'},
'context' => $item->{'context'},
)
);
} else {
$out = $this->column_link( $connector_title, 'connector', $item->{'connector'} );
$out .= '<br />&#8627;&nbsp;';
$out .= $this->column_link(
$context_title,
array(
'connector' => $item->{'connector'},
'context' => $item->{'context'},
)
);
}
$out = $this->column_link( $connector_title, 'connector', $item->{'connector'} );
$out .= '<br />&#8627;&nbsp;';
$out .= $this->column_link(
$context_title,
array(
'connector' => $item->{'connector'},
'context' => $item->{'context'},
)
);
break;

case 'action':
Expand Down

1 comment on commit 539d24f

@frankiejarrett
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was a good idea at first, I had mentioned it earlier in #484 (comment).

But after thinking about it a little more, I think it could actually confuse users. So in this commit I've removed the automatic hiding of the Connector from the Context column if the names match.

Please sign in to comment.