IP addresses in exlude rules not saved correctly

[tyrann0us]

Bug Report

Expected Behavior

Exclude rules should be saved correctly, even if some of them do not contain IP addresses.

Actual Behavior

If there are multiple exclude rules and some of them have no IP address(es) set, settings are not saved correctly. The set IP addresses are then assigned to the wrong authors or roles, because they are displayed one after the other, ignoring whether an IP address was set in the current row at all.

Steps to Reproduce the Problem

1. Create multiple exclude rules
2. Set IP addresses only for some rules
3. Save settings

Screenshots

Before save

After save

System Information

• Stream plugin version: dev-fix/ip-address
• WordPress version: 4.9.11
• PHP version: 7.2.0
• Browser: Google Chrome 77.0
• Computer operating system: macOS Mojave

[kasparsd]

Thanks for the reporting the issue @tyrann0us!

I could replicate the issue and it's probably caused by the way the form uses non-indexed input field names name[] which fails when some of them have an empty value.

[kasparsd]

@tyrann0us Could you please test with the fix/1035-exclude-rules-table branch? You will probably need to run npm run build to re-build the minified JS files with the latest changes.