Fix IP exclude rules settings #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Sep 26, 2019
|
|
||
| $( 'tr:not(.hidden) select.select2-select', $excludeList ).each( | ||
| function() { | ||
| $( this ).select2( 'destroy' ); |
There was a problem hiding this comment.
Don't recreate the select2 fields for rows with them already present.
kasparsd
commented
Sep 26, 2019
|
|
||
| // Ugly hack to ensure we always pass an empty value or the order of rows gets messed up. | ||
| if ( ! firstSelected.length ) { | ||
| $( this ).append( '<option selected="selected"></option>' ); |
There was a problem hiding this comment.
This is the core fix -- we add a dummy option and mark it selected to ensure it gets delivered to the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1035.
HTML
selectelements with nothings selected don't get added to the POST request so the exclude conditions with empty IP rules get moved up to previous rules if they don't have an IP address rule.Checklist
contributing.md).