Gravity Forms - Error Saving form

[mrgrt]

Bug Report

Expected Behavior

Save Gravity form without any errors.

Actual Behavior

Save Gravity Form and get an error "There was an error saving your form. To avoid losing your work, click the Save button to save your form and reload the page."

Steps to Reproduce the Problem

1. Go to Gravity Form
2. Hit Save to update the form
3. Error shows
4. We have deactivated all other plugins except stream and gravity forms and switched to a default theme.

Screenshots/Error logs

System Information

• Stream plugin version: 3.9.3
• WordPress version: 6.3
• PHP version: 8.0
• Browser: Chrome 115
• Computer operating system: macOS (Ventura)

[kasparsd]

Thanks for reporting the issue @mrgrt!

The problem appears to be caused by the gravity forms save handler here:

stream/connectors/class-connector-gravityforms.php

Lines 227 to 242 in 4fb568d

	$this->log(
	sprintf(
	/* translators: %1$s a form title, %2$s a status (e.g. "Contact Form", "created") */
	__( '"%1$s" form %2$s', 'stream' ),
	$title,
	$is_new ? esc_html__( 'created', 'stream' ) : esc_html__( 'updated', 'stream' )
	),
	array(
	'action' => $is_new,
	'id' => $id,
	'title' => $title,
	),
	$id,
	'forms',
	$is_new ? 'created' : 'updated'
	);

setting some expected placeholder data for the $message variable (first argument passed to this method):

stream/classes/class-connector.php

Line 170 in 4fb568d

$message = $data['message'];

which is not matching up with the argument list passed to the logger:

stream/classes/class-log.php

Line 139 in 4fb568d

'summary' => (string) vsprintf( $message, $args ),

Could it be that your form name or any of the data contains the % character? Could you please share the exact form setup to help replicate the issue?

[ocean90]

Related: #1443

[tharsheblows]

Related: #1489