Fix Uncaught ValueError in Gravity Forms and WordPress SEO connectors #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1445. Also tweaks to unit tests, adds $mock to class and uses `onlyMethods()` in WPSEO tests mock.
delawski
reviewed
Jul 18, 2024
There was a problem hiding this comment.
@tharsheblows Thank you for working on this fix. I left some feedback, please check it out.
2 tasks
delawski
approved these changes
Jul 19, 2024
…s-log # Conflicts: # tests/bootstrap.php
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1489, #1443, #1445
Adds in method for escaping the % character for use in log messages. There are other ways to do this which involve fixing the problem in the
log()method but for back compat and in case anyone has extended this, I think we should stick with this way.I've also enabled the debug.log in the local environment.
Checklist
contributing.md).Release Changelog