Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start Xdebug automatically, use sessionkey instead #1510

Closed
wants to merge 2 commits into from

Conversation

delawski
Copy link
Contributor

@delawski delawski commented Jul 18, 2024

This change prevents console errors when running PHPUnit tests as described in #1508 (comment)

Xdebug will no longer be automatically enabled whenever a request comes in. Instead, a request should contain a sessionkey added by a browser extension like Xdebug helper.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).

@delawski delawski added the tooling Development and deployment tooling improvements label Jul 18, 2024
@delawski delawski added this to the 4.0.1 milestone Jul 18, 2024
@delawski delawski requested a review from tharsheblows July 18, 2024 15:53
@delawski delawski changed the title Let browser helper start Xdebug to prevent warnings in tests Do not start Xdebug automatically, use sessionkey instead Jul 18, 2024
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delawski I use xdebug with phpunit a lot 😅 -- but I do think we should sort the underlying issue of "don't show warnings or deprecations before the unit tests" if possible. This isn't an issue with running the tests in php 7.4 but is in php 8.2 even with the correct phpunit.xml settings; they're still before the tests for some reason.

Can we address this in this issue? #1278

@delawski
Copy link
Contributor Author

This is superseded by #1511.

@delawski delawski closed this Jul 19, 2024
@delawski delawski deleted the fix/xdebug-with-phpunit branch July 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development and deployment tooling improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants