Disabled connectors should be removed from default queries and filter dropdowns

[frankiejarrett]

We recently introduced the ability to enable/disable Connectors via its very own Settings tab (see #17). The idea here is that when a Connector is unchecked, activity will no longer be logged for any action within that connector.

However, it doesn't mean that previous activity may not exist, so we have not yet made this setting reflect in the Record filter dropdowns.

I think they should be removed from these filter dropdowns and they should also be omitted from default record query results.

The only way to see past records belonging to disabled connectors would be to query them explicitly.

[shadyvb]

I think we should introduce an option that controls whether they're - inactive connectors - visible or not in filters and in record list, since some users would like to stop recording specific activity, but still need to examine previous ones, and hiding that information behind manual queries would not be an efficient option for some.

[frankiejarrett]

@shadyvb I would have to disagree somewhat with this idea. The vast majority of users will expect that making a connector "inactive" will mean it should not be tracked AND it should not be seen in the filter dropdowns or in the Stream.

For those rare number of users who would want to still want to see this in the Stream (like perhaps as you mentioned they were tracking these at one time, but decided to stop tracking) we could provide some filter in the developer documentation for allowing all connectors to still appear, and ignore the inactive states.

But I feel strongly that making another UI option just for this scenario just isn't unnecessary.

[shadyvb]

@fjarrett I perfectly agree with the filter idea, wasn't fixed on introducing a UI option, merely a way to override the filters when/if needed.

[frankiejarrett]

👍