-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disabled connectors from default queries and filter dropdowns. #258
Conversation
Introduce new filter: 'wp_stream_list_table_show_disabled_connectors' to toggle the visibility.
Introduce new filter: 'wp_stream_list_table_hide_disabled_connectors' for toggling the visibility.
Introduce 'wp_stream_list_table_hide_disabled_connectors_records' filter
Sorry about the duplicate commit there 😉 |
@kucrut My Stream is empty! Does this require that the Settings be re-saved? |
@fjarrett No. This may have something to do with the |
@fjarrett c7e9472 should fix it. I just realized that the types of the setting values are not consistent. I ran into this problem before in another plugin. For example: what if the value of a setting field = Well, this could be logged in a new issue, but I'm not sure. |
@fjarrett Also, please reword the filter names as needed. @westonruter I know you ❤️ long filter names 😉 |
@kucrut I keep trying to uncheck "Installer" in the Connectors tab, and when I Save Changes it becomes checked again. |
@kucrut Also, the Connectors dropdown filter won't display anything. |
Introduce WP_Stream_Settings::get_active_connectors()
@fjarrett This should be good now. |
@kucrut The dropdown is back, but I still can't uncheck anything. It keeps checking them upon save. |
@kucrut Sorry! This issue was being caused by another plugin that was activated. |
@kucrut This is working quite nicely. Thank you. |
Remove disabled connectors from default queries and filter dropdowns.
Fixes #223