Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabled connectors from default queries and filter dropdowns. #258

Merged
merged 5 commits into from
Feb 19, 2014

Conversation

kucrut
Copy link
Contributor

@kucrut kucrut commented Feb 19, 2014

Fixes #223

Dzikri Aziz added 3 commits February 20, 2014 03:10
Introduce new filter: 'wp_stream_list_table_show_disabled_connectors'
to toggle the visibility.
Introduce new filter: 'wp_stream_list_table_hide_disabled_connectors'
for toggling the visibility.
Introduce 'wp_stream_list_table_hide_disabled_connectors_records' filter
@kucrut
Copy link
Contributor Author

kucrut commented Feb 19, 2014

Sorry about the duplicate commit there 😉

@frankiejarrett
Copy link
Contributor

@kucrut My Stream is empty! Does this require that the Settings be re-saved?

screen shot 2014-02-19 at 3 40 34 pm

@kucrut
Copy link
Contributor Author

kucrut commented Feb 19, 2014

@fjarrett No. This may have something to do with the __placeholder__ value. I'm checking it out.

@kucrut
Copy link
Contributor Author

kucrut commented Feb 19, 2014

@fjarrett c7e9472 should fix it. I just realized that the types of the setting values are not consistent. I ran into this problem before in another plugin.

For example: what if the value of a setting field = mysql. the is_callable() check will then call the function and boom! 😸

Well, this could be logged in a new issue, but I'm not sure.

@kucrut
Copy link
Contributor Author

kucrut commented Feb 19, 2014

@fjarrett Also, please reword the filter names as needed.

@westonruter I know you ❤️ long filter names 😉

@frankiejarrett
Copy link
Contributor

@kucrut I keep trying to uncheck "Installer" in the Connectors tab, and when I Save Changes it becomes checked again.

@frankiejarrett
Copy link
Contributor

@kucrut Also, the Connectors dropdown filter won't display anything.

screen shot 2014-02-19 at 4 16 20 pm

Introduce WP_Stream_Settings::get_active_connectors()
@kucrut
Copy link
Contributor Author

kucrut commented Feb 19, 2014

@fjarrett This should be good now.

@frankiejarrett
Copy link
Contributor

@kucrut The dropdown is back, but I still can't uncheck anything. It keeps checking them upon save.

screen_shot_2014-02-19_at_5_03_15_pm

screen_shot_2014-02-19_at_5_03_27_pm

@frankiejarrett
Copy link
Contributor

@kucrut Sorry! This issue was being caused by another plugin that was activated.

@frankiejarrett
Copy link
Contributor

@kucrut This is working quite nicely. Thank you.

frankiejarrett added a commit that referenced this pull request Feb 19, 2014
Remove disabled connectors from default queries and filter dropdowns.
@frankiejarrett frankiejarrett merged commit eef4170 into develop Feb 19, 2014
@frankiejarrett frankiejarrett deleted the issue-223 branch February 19, 2014 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled connectors should be removed from default queries and filter dropdowns
2 participants