Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu name not appearing in summary if deleted while assigned #29

Closed
frankiejarrett opened this issue Dec 7, 2013 · 2 comments
Closed
Labels

Comments

@frankiejarrett
Copy link
Contributor

There is a special circumstance in which the menu name does not appear in the record summary. When a menu is currently assigned to a theme location and is suddenly deleted, two actions are performed.

Firstly the menu is logged as deleted, and secondly, it is logged as unassigned from the theme location.

screen_shot_2013-12-07_at_1 00 21_am

This causes the menu name to be omitted from the second record. It would be ideal if there was a way to switch the order of the two in this case.

@shadyvb
Copy link
Contributor

shadyvb commented Dec 7, 2013

@fjarrett Currently, after #23, the unassigned action should not be logged at all. I think this is one of those cases where we would need fewer log entries since one would logically include the other ( deleted means it was also unassigned from any location ).

Thoughts ?

@frankiejarrett
Copy link
Contributor Author

@shadyvb Agreed! The deleted action is enough.

frankiejarrett added a commit that referenced this issue Aug 22, 2014
Show noice in form if no triggers exist, Fixes #18
jonathanbardo pushed a commit that referenced this issue Aug 22, 2014
Dependent on stream issue #330
lukecarbis added a commit that referenced this issue Sep 1, 2014
Migrate legacy records to the cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants