Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context for Pages #8

Closed
6 tasks done
frankiejarrett opened this issue Nov 27, 2013 · 5 comments
Closed
6 tasks done

Add context for Pages #8

frankiejarrett opened this issue Nov 27, 2013 · 5 comments
Assignees
Milestone

Comments

@frankiejarrett
Copy link
Contributor

Page actions should be added as a core context of the Stream plugin.

Possible actions:

  • Created
  • Updated
  • Published
  • Unpublished
  • Trashed
  • Deleted
@ghost ghost assigned shadyvb Nov 28, 2013
@shadyvb
Copy link
Contributor

shadyvb commented Dec 1, 2013

@fjarrett I believe this is integrated into the posts connector we already have, and i don't think making that connector ( posts ) manage posts [post_type=post] only is a good thing, now that everybody is using custom post types.

@frankiejarrett
Copy link
Contributor Author

@shadyvb Yes, you're right. Perhaps the connector should be "Posts" and the context should always be the post_type label (e.g. Posts, Pages, My Custom Posts, etc.)

shadyvb added a commit that referenced this issue Dec 5, 2013
@frankiejarrett
Copy link
Contributor Author

@shadyvb Nicely done! But we should also update the summary to use the post type's singular label.

For instance, this summary should say download instead of post:

screen_shot_2013-12-07_at_1 45 15_am

@shadyvb
Copy link
Contributor

shadyvb commented Dec 7, 2013

@fjarrett Fixed in 87caf70

@frankiejarrett
Copy link
Contributor Author

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants