-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooling update and WPCS cleanup #1016
Merged
Merged
Changes from all commits
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
014f7a4
Add license info and meta data
kasparsd e4b4f6a
Validate composer.json during linting
kasparsd 7f42edd
Use standard naming to ensure phpcs can find it
kasparsd 1b831ee
Add helpers for running the linter
kasparsd c8667cd
Automatic WPCS fixes
kasparsd 94f0bcf
Exclude node modules
kasparsd cfc447a
Exclude a few for now
kasparsd c2ca650
Remove unused
kasparsd 2cd3954
Skip these for now
kasparsd dc1909b
This too
kasparsd a158b41
Optimize the autoloader
kasparsd ded8b5b
Lint using local tools instead
kasparsd a7cfe1d
Switch to eslint to match WP core
kasparsd fb048c0
Format per WPCS
kasparsd 16de83d
Use eslint instead
kasparsd 0273030
Update deps
kasparsd 985193a
Unused
kasparsd 1dc7cdb
Stick to legacy for now
kasparsd d363b5e
Add a basic dev environment
kasparsd c9bb5d0
Ingore the local Vagrant ref
kasparsd 7418f50
And the console output
kasparsd a7ea87e
Remove duplicates
kasparsd dec86ed
Not used for now
kasparsd 05d926f
Fake PHP platform to ensure deps match
kasparsd 1be1d55
eslint —fix automatically
kasparsd ea73054
Ignore the build directory
kasparsd daa5835
Cleanup comments
kasparsd 70a3dca
Set global
kasparsd d289291
Rename to avoid matching another var
kasparsd c328da9
Warn for now
kasparsd cc65c60
jQuery from global
kasparsd e1a4739
Strict per eslint
kasparsd 74c9531
Define globals
kasparsd d52b758
Avoid local shadows
kasparsd 5440d91
Scope local references
kasparsd c0cb1ae
Better slogan
kasparsd c0b1f0d
Stick to underscores for now
kasparsd 7995254
Only warn about comments
kasparsd 80541db
Specify a version
kasparsd 77e0c8f
Load in header for now
kasparsd 15feef4
Specify the versions
kasparsd ea5e50f
Allow local overrides
kasparsd 5a1f7f6
Ignore phpcs warnings for now
kasparsd 611855b
Remove since not used
kasparsd 1f5565c
Add test reporting
kasparsd 386fd7b
Exclude libraries
kasparsd 22175a5
Include wp-cli deps for tests
kasparsd 2b00e0c
Help resolve deps
kasparsd d3d36ef
Include core phpunit deps
kasparsd 00d1e47
Introduce local config file for unit tests
kasparsd 9a4351d
Build our custom image
kasparsd 62b0c3c
Add helpers
kasparsd 69853a7
Add commands to work with dev env
kasparsd 61ad701
Put in the root instead
kasparsd c5f8ecc
Reference the source directory which is always available
kasparsd ff91dc4
Cleanup bootstrap
kasparsd 1335904
Fix references
kasparsd 2b69a0d
Add a helper for running phpunit
kasparsd b316947
Match the rest of includes
kasparsd 7c2d6db
Revert "Match the rest of includes"
kasparsd 0633063
This is the default… maybe
kasparsd d7c1614
Setup the site on the first go
kasparsd 25e4ab1
PHPunit does this for us
kasparsd eb35bd1
Ensure Apache can write to the filesystem.
kasparsd 9c7dcd7
Remove for now
kasparsd c8c9f77
Introduce a command instead
kasparsd 844a770
Include additional files for coverage reporting
kasparsd 28bf5ee
Sort things
kasparsd ea8e490
Do include
kasparsd e55368e
Secify what we have
kasparsd 0d98b38
Add a reminder for now
kasparsd 32d155d
Comment out for now
kasparsd 9648edc
Prepare for bright future
kasparsd ffb6ce9
Exclude the CLI command for now
kasparsd 08152e3
Exclude feeds that output things
kasparsd 0e58bb0
Do opt-in for clarity
kasparsd 920f6f5
Enable reporting
kasparsd 3ca8474
Remove the capture all
kasparsd 642347a
Not needed for the plugin, yet
kasparsd a17bdb8
Always run the test report
kasparsd 290c707
Revert "Always run the test report"
kasparsd 4b8399a
Debug PHPunit report
kasparsd 145d6bc
Run unit tests inside docker container
kasparsd e4cce21
Temp hide versions for quicker debugging
kasparsd 356d105
Don’t use dev-lib
kasparsd 9ffdcb9
Don’t assume a container is up
kasparsd 0298539
Ensure we have the test db too
kasparsd b44df66
Always restart
kasparsd ed73ff9
Introduce native commands
kasparsd 37e50e6
No need to change dir
kasparsd 5b2b73d
Assume the containers are running
kasparsd 6942f3e
Use the new commands
kasparsd c488838
Stick with dev-lib for now
kasparsd 041be90
Debug reports
kasparsd 0d992e8
Lock to avoid config changes with updates
kasparsd a47049c
Debug phpunit
kasparsd 22d6c48
Spacing
kasparsd b0e990f
Enable mysql service
kasparsd 87de069
Use the docker runners for unit tests
kasparsd 18f35ca
Remove debugging info
kasparsd 3330cde
Include debugging information
kasparsd 618326d
Add dev-lib as a Composer dep
kasparsd 81310ca
Match recomendations
kasparsd c4141e4
Debug the working directory
kasparsd d84c6a9
Require Git for things
kasparsd 20dc41f
Use docker everywhere
kasparsd 903d136
Debug local environment vars
kasparsd 101869c
Add back for readme purposes
kasparsd 56d0a7b
Haha, too much composer in my life
kasparsd 474be37
Ensure the uploads directory exists
kasparsd 37d825d
Explain why we need the dir
kasparsd aef4432
Didn’t help
kasparsd a44ea55
Run the init check just once
kasparsd 94471c3
Add a reminder
kasparsd 2f3cc4f
Describe what these do
kasparsd de84526
Stick to the current setup for now
kasparsd a6b6caa
Remove leftovers
kasparsd befc71c
Try another way
kasparsd 9bb66a5
Document the local setup
kasparsd 5575207
Introduce a dedicated readme for devs
kasparsd e28fdbe
Mention specific things
kasparsd ecdc55d
Documentation first
kasparsd 22726f4
Move to the right spot
kasparsd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
coverage_clover: tests/reports/clover.xml | ||
json_path: tests/reports/coveralls-upload.json | ||
service_name: travis-ci |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/ui/lib/ | ||
**/*.min.js | ||
/vendor/ | ||
/node_modules/ | ||
/build/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"env": { | ||
"browser": true | ||
}, | ||
"extends": [ | ||
"plugin:@wordpress/eslint-plugin/es5" | ||
], | ||
"rules": { | ||
"camelcase": "off", | ||
"no-alert": "off", | ||
"vars-on-top": "warn" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
load File.join( | ||
File.dirname(__FILE__), | ||
"vendor/wpsh/local/Vagrantfile" | ||
) | ||
|
||
Vagrant.configure(2) do |config| | ||
config.vm.hostname = "stream" | ||
|
||
# Wait 10 seconds before the docker containers are up. | ||
config.vm.provision "shell", | ||
inline: "sleep 10", | ||
run: "always" | ||
|
||
# Setup the WP sites. | ||
config.vm.provision "shell", | ||
path: "local/vagrant/setup-wp.sh", | ||
run: "always", | ||
env: { | ||
"DOCKER_COMPOSE_FILE" => "/vagrant/docker-compose.yml" | ||
} | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to eslint.