-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store build releases in a distribution repository #1074
Conversation
Store a local release as well
# Conflicts: # .travis.yml
This needed all_branches: true to work with the `on` conditional
@kopepasah This is now working -- here is a bundle being pushed to the xwp/stream-dist repository with a matching branch xwp/stream-dist@26d58e9 Could you please review this? |
@@ -20,11 +20,13 @@ jobs: | |||
env: | |||
WORDPRESS_IMAGE_VERSION: php7.2 | |||
|
|||
- name: Test Release Bundle | |||
script: npm run release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a standalone script to test the packaging scripts which would previously only run during the tag build which is way too late to fail.
if: branch IS present AND type = push | ||
script: npm run release | ||
before_deploy: | ||
- openssl aes-256-cbc -K $encrypted_49634e5b1863_key -iv $encrypted_49634e5b1863_iv -in ./local/travis/travis_deploy_key.enc -out ~/.ssh/id_rsa -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary because Travis doesn't support custom SSH keys for public repos so we need to manually add a custom SSH key associated with the @team-atlas-bot machine user which has the necessary write permissions.
@@ -65,6 +65,7 @@ module.exports = function( grunt ) { | |||
'languages/*', | |||
'readme.txt', | |||
'readme.md', | |||
'composer.json', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer packages must have this in the root.
@@ -0,0 +1,38 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we take the release bundle and push it to the stream-dist
repository. We always push the branch and add a tag if this is a tag build on travis as indicated by $TRAVIS_TAG
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasparsd these changes look good to me.
Fixes #1073.