-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments connector test implemented #1134
Conversation
c5dad00
to
7a96864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love these tests!
docker-compose.yml
Outdated
@@ -20,7 +20,7 @@ services: | |||
- mysql | |||
- db_phpunit | |||
ports: | |||
- "80:80" | |||
- "8080:80" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep using port 80
for consistency with the developer docs? Currently they're referencing stream.local
without the port number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, must have forgot to change it back. I'll be sure to fix it when I rebase
7a96864
to
58502a2
Compare
58502a2
to
d02b2f5
Compare
d02b2f5
to
880b3ff
Compare
Partially fixes #1093
Summary checklist
delete_comment
callback testedit_comment
callback testspam_comment
callback testtransition_comment_status
callback testtrash_comment
callback testuntrash_comment
callback testwp_insert_comment
callback testcomment_duplicate_trigger
callback test