GravityForms connector test implemented #1139

kidunot89 · 2020-07-10T16:33:46Z

Partially fixes #1093

Summary checklist

tests/bootstrap.php

tests/tests/connectors/test-class-connector-gravityforms.php

kopepasah · 2020-07-30T19:52:00Z

tests/tests/connectors/test-class-connector-gravityforms.php

+
+		// Do stuff.
+		$notification = array(
+			'id'      => uniqid(),


Align assignments.

tests/tests/connectors/test-class-connector-gravityforms.php

kopepasah · 2020-07-30T22:42:29Z

composer.json

@@ -15,7 +15,8 @@
    "wp-cli/wp-cli-bundle": "^2.2",
    "wp-coding-standards/wpcs": "^2.2",
    "wp-phpunit/wp-phpunit": "^5.4",
-    "wpsh/local": "^0.2.3"
+    "wpsh/local": "^0.2.3",
+    "wp-premium/gravityforms": "^2.4.17"


@kidunot89 we need to find another way to pull in this plugin and test. While GPL code on in wp-premium Org is technically legal (I'm not a lawyer 🤐), we will not support it as it takes away from the developers who built these plugins and poses as a potential security risk.

Maybe we can pull it in as a zip someway? I have a developer's license, so access is not a problem.

I'm open to ideas, is there a recommend method you have for pull this plugin in?

I am also open to ideas. One that comes to mind is we have a private S3bucket (or other storage service) from which we can read with private keys in Github. The we can use an archive installer with Composer to pull in those packages.

I checked, but did not find any way to add files to Github or Travis for pulling in the data, but the above solution may be a good start.

@kasparsd any ideas?

Honestly, I'm not sure how to handle this. How about we skip the tests if the dependency is not found for now?

kasparsd

@kidunot89 The tests alone look great. Could we get those merged in now and leave the plugin dependency out of tracking/dependency list until we find a solid solution for working with commercial plugins that don't have source code available publicly.

kidunot89 · 2020-08-18T19:42:28Z

@kasparsd I'm not sure about leaving the plugin out, since the tests relies on it.

derekherman · 2020-11-14T00:34:17Z

@kidunot89 and @kasparsd In order to add the plugin it would need to be done in a way that is progressive and legal. It should not fail a build if the plugin is missing, so tests should only run if installed and active, and while we can install it with Composer I'm not sure if we can gracefully fail.

At any rate the minimum changes are that we need to add this object to the repositories array.

{
  "type": "package",
  "package": {
    "name": "gravityforms/gravityforms",
    "version": "2.4.21.3",
    "type": "wordpress-plugin",
    "dist": {
      "type": "zip",
      "url": "https://www.gravityhelp.com/wp-content/plugins/gravitymanager/api.php?op=get_plugin&slug=gravityforms&key={%GRAVITYFORMS_KEY}"
    },
    "require": {
      "composer/installers": "^1.4",
      "gotoandplay/gravityforms-composer-installer": "^2.3"
    }
  }
}

Also, we will need to add "gravityforms/gravityforms": "2.4.21.3" to require-dev and find a way to fail gracefully if the environment variable for the key it either missing or invalid. Locally you would also need to create a .env file and add GRAVITYFORMS_KEY=YOUR_SECRET_KEY and for the build to pass we can add the elite key we use for XWP projects to Travis CI.

There are really only two hurdles:

Make tests run with/without plugin
Degrade gracefully in Composer

kidunot89 · 2020-11-25T17:39:27Z

@kasparsd @ivankruchkoff The GravityForms package has been updated as @derekherman suggested, and I've added the GRAVITYFORMS_KEY as a secret in Travis-CI. If either of your reviews approve this should finally be all ready for merging.

kasparsd

@kidunot89 I tried looking into the Travis issue but I'm not sure what is happening. Could it be that some of the dependencies were updated via composer update? It appears to be happening here:

https://github.com/symfony/polyfill-php80/blob/dc3063ba22c2a1fd2f45ed856374d79114998f91/bootstrap.php#L23

kasparsd · 2021-02-23T14:40:18Z

composer.json

+        "type": "wordpress-plugin",
+        "dist": {
+          "type": "zip",
+          "url": "https://www.gravityhelp.com/wp-content/plugins/gravitymanager/api.php?op=get_plugin&slug=gravityforms&key={%GRAVITYFORMS_KEY}"


Does that mean that only people with GF key will be able to work on the plugin?

@kasparsd Yea, it is. 🤔 This might need some further tooling.

I think we should skip GravityForms connector test unless the developer installs it as a dev specifically with composer. Then can probably move the whole GravityForms install process into the Travis-CI script and take it out of the composer.json.

@kasparsd ☝️ What do you think?

Yes, that is a good idea! We could even have another composer.json file for installing these external dependencies.

kidunot89 · 2021-03-02T01:35:22Z

.travis.yml

+  - |
+    composer config repositories."1"  "{
+      \"type\": \"package\",
+      \"package\": {
+        \"name\": \"gravityforms/gravityforms\",
+        \"version\": \"2.4.21.3\",
+        \"type\": \"wordpress-plugin\",
+        \"dist\": {
+          \"type\": \"zip\",
+          \"url\": \"https://www.gravityhelp.com/wp-content/plugins/gravitymanager/api.php?op=get_plugin&slug=gravityforms&key=$GRAVITYFORMS_KEY\"
+        },
+        \"require\": {
+          \"composer/installers\": \"^1.4\",
+          \"gotoandplay/gravityforms-composer-installer\": \"^2.3\"
+        }
+      }
+    }"
  - npm install
+  - composer require --dev gravityforms/gravityforms:2.4.21.3


@kasparsd This should do the trick. I don't think there is a need for an alternative composer.json, but it does make the repositories array and object.

But I revert it in the before_deploy 🤔.

kidunot89 · 2021-03-02T01:36:31Z

.travis.yml

@@ -50,6 +50,7 @@ jobs:
      if: branch IS present AND type = push
      script: npm run release
      before_deploy:
+        - git restore composer.json


@kasparsd This is to revert the changes made in the install.

kidunot89 added the work in progress Issue or pull request is still under development (DO NOT MERGE) label Jul 10, 2020

kidunot89 requested review from kasparsd and derekherman July 10, 2020 16:33

kidunot89 self-assigned this Jul 10, 2020

kidunot89 changed the title ~~Tests/gravityforms connector~~ GravityForm connector test implemented Jul 10, 2020

kidunot89 changed the title ~~GravityForm connector test implemented~~ GravityForms connector test implemented Jul 10, 2020

kidunot89 removed the work in progress Issue or pull request is still under development (DO NOT MERGE) label Jul 16, 2020

kidunot89 requested a review from kopepasah July 24, 2020 17:18

kopepasah reviewed Jul 30, 2020

View reviewed changes

tests/bootstrap.php Outdated Show resolved Hide resolved

kopepasah suggested changes Jul 30, 2020

View reviewed changes

kopepasah reviewed Jul 30, 2020

View reviewed changes

kidunot89 requested a review from kopepasah August 3, 2020 19:21

kidunot89 force-pushed the tests/gravityforms-connector branch from 6ed189d to 2e84b50 Compare August 6, 2020 18:09

kasparsd reviewed Aug 14, 2020

View reviewed changes

kidunot89 force-pushed the tests/gravityforms-connector branch from 2e84b50 to 99aff43 Compare November 25, 2020 17:23

kidunot89 requested review from kasparsd and removed request for kopepasah November 25, 2020 17:25

kidunot89 requested a review from ivankruchkoff November 25, 2020 17:39

kidunot89 added this to the 3.7.0 milestone Jan 4, 2021

GravityForms connector test implemented.

26e0f36

kidunot89 force-pushed the tests/gravityforms-connector branch from 99aff43 to f06174b Compare February 12, 2021 18:52

kidunot89 force-pushed the tests/gravityforms-connector branch from f06174b to fe9f8f1 Compare February 19, 2021 23:50

kidunot89 mentioned this pull request Feb 22, 2021

Release 3.7.0 #1234

Merged

7 tasks

kidunot89 force-pushed the tests/gravityforms-connector branch from fe9f8f1 to 71ce5fc Compare February 22, 2021 18:43

GravityForms dependencies updated.

74148a3

kidunot89 force-pushed the tests/gravityforms-connector branch from 71ce5fc to 74148a3 Compare February 22, 2021 19:03

kasparsd reviewed Feb 23, 2021

View reviewed changes

kidunot89 force-pushed the tests/gravityforms-connector branch from 7af0429 to 01a914d Compare March 2, 2021 01:17

"GravityForms" installation added to .travis.yml

595d5ae

kidunot89 force-pushed the tests/gravityforms-connector branch from 01a914d to 595d5ae Compare March 2, 2021 01:32

kidunot89 commented Mar 2, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GravityForms connector test implemented #1139

GravityForms connector test implemented #1139

kidunot89 commented Jul 10, 2020 •

edited

Loading

kopepasah Jul 30, 2020

kopepasah Jul 30, 2020

kopepasah Jul 30, 2020

kidunot89 Jul 30, 2020 •

edited

Loading

kopepasah Jul 31, 2020

kasparsd Aug 14, 2020

kasparsd left a comment

kidunot89 commented Aug 18, 2020

derekherman commented Nov 14, 2020

kidunot89 commented Nov 25, 2020 •

edited

Loading

kasparsd left a comment

kasparsd Feb 23, 2021

kidunot89 Feb 25, 2021

kidunot89 Feb 25, 2021 •

edited

Loading

kidunot89 Feb 25, 2021

kasparsd Feb 27, 2021

kidunot89 Mar 2, 2021

kidunot89 Mar 2, 2021 •

edited

Loading

GravityForms connector test implemented #1139

Are you sure you want to change the base?

GravityForms connector test implemented #1139

Conversation

kidunot89 commented Jul 10, 2020 • edited Loading

Summary checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kidunot89 Jul 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kasparsd left a comment

Choose a reason for hiding this comment

kidunot89 commented Aug 18, 2020

derekherman commented Nov 14, 2020

kidunot89 commented Nov 25, 2020 • edited Loading

kasparsd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kidunot89 Feb 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kidunot89 Mar 2, 2021 • edited Loading

Choose a reason for hiding this comment

kidunot89 commented Jul 10, 2020 •

edited

Loading

kidunot89 Jul 30, 2020 •

edited

Loading

kidunot89 commented Nov 25, 2020 •

edited

Loading

kidunot89 Feb 25, 2021 •

edited

Loading

kidunot89 Mar 2, 2021 •

edited

Loading