Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack connector test implemented #1153

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Jetpack connector test implemented #1153

merged 4 commits into from
Mar 26, 2021

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Aug 5, 2020 •
edited
Loading

Partially fixes #1093

Summary Checklist

  • jetpack_log_entry callback test implemented and passing.
  • jetpack_module_configuration_load_monitor callback test implemented and passing.
  • sharing_get_services_state callback test implemented and passing.
  • check function test implemented and passing.
  • track_post_by_email function test implemented and passing.

@kidunot89 kidunot89 self-assigned this Aug 5, 2020
@kidunot89 kidunot89 changed the title Jetpack connector test implemented WIP Jetpack connector test implemented Aug 5, 2020
@kidunot89 kidunot89 added needs discussion The issue/PR needs further discussion before a solution can be implemented work in progress Issue or pull request is still under development (DO NOT MERGE) labels Aug 5, 2020
@kidunot89 kidunot89 force-pushed the tests/jetpack-connector branch from 25b070c to 7a7e12b Compare August 21, 2020 17:21
@kidunot89 kidunot89 changed the title WIP Jetpack connector test implemented Jetpack connector test implemented Aug 21, 2020
@kidunot89 kidunot89 requested a review from kasparsd August 21, 2020 17:24
@kidunot89 kidunot89 removed needs discussion The issue/PR needs further discussion before a solution can be implemented work in progress Issue or pull request is still under development (DO NOT MERGE) labels Aug 26, 2020
dero
dero approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidunot89 LGTM, really good work here.

@kidunot89 kidunot89 added this to the 3.7.0 milestone Jan 4, 2021
@kidunot89 kidunot89 force-pushed the tests/jetpack-connector branch from d1dd979 to f75574b Compare February 10, 2021 17:07
@kidunot89 kidunot89 mentioned this pull request Feb 22, 2021
Merged
7 tasks
@kidunot89 kidunot89 merged commit ea3c7fd into develop Mar 26, 2021
@kidunot89 kidunot89 deleted the tests/jetpack-connector branch March 26, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dero dero dero approved these changes

@kopepasah kopepasah Awaiting requested review from kopepasah

@derekherman derekherman Awaiting requested review from derekherman

@kasparsd kasparsd Awaiting requested review from kasparsd

Assignees

@kidunot89 kidunot89

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage
3 participants
@kidunot89 @kasparsd @dero