Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default options provided to "wp_stream_auto_purge" callbacks. #1159

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Aug 20, 2020

Fixes #1056

Checklist

Provides Settings::default_settings() as the default value for all get_site_option( 'wp_stream_network' ); and get_option( 'wp_stream' ); calls to avoid skipping record purging when no settings are saved in the database, which seems to be the root cause of #1056.

@kidunot89 kidunot89 requested a review from kasparsd August 20, 2020 19:28
@kidunot89 kidunot89 self-assigned this Aug 20, 2020
@laxbobber
Copy link

Any idea when this will be included in a release? I've got 150 sites piling up records that I would love to purge.

@kidunot89
Copy link
Contributor Author

@kasparsd @dero ☝️

@kidunot89 kidunot89 added this to the 3.6.1 milestone Jan 4, 2021
@kidunot89 kidunot89 force-pushed the bugfix/old-record-deleted branch from 9d3d501 to 9256fdb Compare January 5, 2021 23:16
@kidunot89 kidunot89 merged commit afef5a9 into develop Jan 5, 2021
@kidunot89 kidunot89 deleted the bugfix/old-record-deleted branch January 5, 2021 23:49
@kidunot89 kidunot89 mentioned this pull request Jan 12, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old records are not being removed
2 participants