Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WHERE statement filter added. #1160

Merged
merged 2 commits into from
Sep 23, 2020
Merged

WHERE statement filter added. #1160

merged 2 commits into from
Sep 23, 2020

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Aug 20, 2020 •
edited
Loading

Fixes #1044 .

Checklist

Adds a filter for modifying the WHERE statement and the records query.

@kidunot89 kidunot89 requested a review from kasparsd August 20, 2020 19:45
@kidunot89 kidunot89 self-assigned this Aug 20, 2020
@kidunot89 kidunot89 added the needs discussion The issue/PR needs further discussion before a solution can be implemented label Aug 20, 2020
dero
dero requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidunot89 Thanks. One question / suggestion.

classes/class-query.php Outdated Show resolved Hide resolved
@kidunot89 kidunot89 force-pushed the feature/stream-db-query-where-filter branch from 06d8ddf to 0d9bc09 Compare September 17, 2020 19:26
@kidunot89 kidunot89 requested a review from dero September 17, 2020 19:26
@kidunot89
Copy link
Contributor Author

@dero you're requested changes have been made. Please re-review.

dero
dero approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@dero dero merged commit 5ed65e1 into develop Sep 23, 2020
@dero dero deleted the feature/stream-db-query-where-filter branch September 23, 2020 16:37
@kasparsd kasparsd mentioned this pull request Oct 14, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dero dero dero approved these changes

@kasparsd kasparsd Awaiting requested review from kasparsd

Assignees

@kidunot89 kidunot89

Labels
enhancement needs discussion The issue/PR needs further discussion before a solution can be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a filter to where db clause
2 participants
@kidunot89 @dero