Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings connector test implemented. #1165

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Aug 28, 2020

Fixes #1093 .

Summary Checklist

  • Test added for all connector callbacks.
  • callback_whitelist_options replaced with callback_allowed_options due to the whitelist_options callback being deprecated for the allowed_options filter.

@kidunot89 kidunot89 requested a review from kasparsd August 28, 2020 20:09
@kidunot89 kidunot89 self-assigned this Aug 28, 2020
@kidunot89 kidunot89 requested a review from dero September 28, 2020 23:33
Copy link
Member

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidunot89 This looks great! One request: can you please update callback_update_option to take parameters in a correct order?

Right now the method signature is:

public function callback_update_option( $option, $value, $old_value )

... but the update_option hook passes the $old_value first. I believe the only thing we need to do is to switch the names of the variables there.

@kidunot89 kidunot89 force-pushed the tests/settings-connector branch from 94f1829 to e428ac4 Compare October 5, 2020 21:45
@kidunot89 kidunot89 requested a review from dero October 5, 2020 21:51
@kidunot89
Copy link
Contributor Author

Fixed 👍

@kidunot89 kidunot89 added this to the 3.6.1 milestone Jan 4, 2021
@kidunot89 kidunot89 merged commit d778c7c into develop Jan 4, 2021
@kidunot89 kidunot89 deleted the tests/settings-connector branch January 4, 2021 19:25
@kidunot89 kidunot89 mentioned this pull request Jan 12, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage
2 participants