Buddypress connector implemented #1211
Open
+846
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
commented
Dec 23, 2020
| public function callback_xprofile_field_before_save( $field ) { | ||
| $this->incoming_field_action = empty( $field->id ) ? 'created' : 'updated'; | ||
| } | ||
|
|
There was a problem hiding this comment.
@ivankruchkoff Set my comment below
kidunot89
commented
Dec 23, 2020
| } | ||
|
|
||
| $action = $this->incoming_field_group_action; | ||
| unset( $this->incomming_field_group_action ); |
There was a problem hiding this comment.
@ivankruchkoff I below this is a better way to capture the incoming field action
kidunot89
force-pushed
the
tests/buddypress-connector
branch
from
e02d472 to
5309c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #1093
Summary checklist
activitycallbacks tested and passing.groupcallbacks tested and passing.optioncallbacks tested and passing.xprofilecallbacks tested and passing.callback_xprofile_group_before_saveandcallback_xprofile_field_before_savecallbacks added to theBuddyPressconnector class to provide a more stable method of capturing the incoming field/field group action that doesn't rely on$wpdb->insert_id.