Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant textdomain loading #1213

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Remove redundant textdomain loading #1213

merged 3 commits into from
Jan 5, 2021

Conversation

szepeviktor
Copy link
Contributor

wp_stream_fail_php_version does it itself.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

@szepeviktor
Remove redundant textdomain loading
6c9a41b 
`wp_stream_fail_php_version` does it itself.
kasparsd
kasparsd approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I wonder why it was added in two places.

@kidunot89 Can you please merge this?

@kidunot89 kidunot89 added this to the 3.6.1 milestone Jan 4, 2021
@kidunot89 kidunot89 merged commit d8be280 into xwp:develop Jan 5, 2021
@szepeviktor szepeviktor deleted the patch-2 branch January 5, 2021 22:16
@szepeviktor
Copy link
Contributor Author

Thank you.

@kidunot89 kidunot89 mentioned this pull request Jan 12, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidunot89 kidunot89 kidunot89 approved these changes

@kasparsd kasparsd kasparsd approved these changes

@ivankruchkoff ivankruchkoff Awaiting requested review from ivankruchkoff

Assignees

@kidunot89 kidunot89

Labels
None yet
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @kasparsd @kidunot89