Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading changes to adapt code to PHP 8.1 #1398

Closed
wants to merge 5 commits into from

Conversation

davefx
Copy link
Contributor

@davefx davefx commented Jan 25, 2023

Fixes #1349 .

I've fixed all the deprecation warnings I've found when running my site against PHP 8.1.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

@simonhammes
Copy link

@davefx Can you fix the conflicts in this PR?

@davefx
Copy link
Contributor Author

davefx commented Apr 3, 2024

@simonhammes Conflicts resolved.
Thanks!

@simonhammes
Copy link

@davefx Thank you very much. There's another deprecation notice that is being triggered on the main "Stream Records" screen:

timezone_name_from_abbr(): Passing null to parameter #1 ($abbr) of type string is deprecated (in classes/class-date-interval.php:46)

I think null should be replaced with an empty string in both timezone_name_from_abbr() calls in this file.

@kasparsd kasparsd added the compatibility PHP or WordPress version compatibility related issue label Jun 17, 2024
@delawski
Copy link
Contributor

This will be superseded by #1494.

@delawski
Copy link
Contributor

The PHP 8 compatibility issues have been addressed in 4.0.1 so I'm closing this PR.

@delawski delawski closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility PHP or WordPress version compatibility related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1: PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
4 participants