Check if entry/lead ID is empty in "gform_post_note_added" action #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn early if it is
kasparsd
reviewed
Sep 13, 2023
| @@ -672,6 +672,11 @@ public function callback_gform_post_note_added( $note_id, $lead_id, $user_id, $u | |||
| unset( $note ); | |||
| unset( $note_type ); | |||
|
|
|||
| // Skip if no entry/lead id (e.g. Save and Continue notifications) | |||
| if( empty( $lead_id ) ) { | |||
There was a problem hiding this comment.
suggestion: Looks like the CI with linter checks isn't running for this pull request but could you please update it to have the space between if and the opening (?
Suggested change
| if( empty( $lead_id ) ) { | |
| if ( empty( $lead_id ) ) { |
kasparsd
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446.
Adds a simple "empty" check on the incoming $lead_id to prevent warnings/notices when "null" is passed under certain circumstances (detailed in issue).
Note: After reviewing the rest of the class I think there's a lot of safety/sanity checks & general updates that could/should be made to this Gravity Forms connector class and there's a lack of PHPUnit tests for this connector as well. Since this PR is relatively simple & straightforward I think it's fine to merge for the time being to fix the immediate notices/warnings problem, and I can submit a more detailed improvement issue/PR in the near future to cover a more proper general refactoring. Let me know if that sounds alright or if you'd prefer to wait on this issue/update until that more proper refactoring is ready
Checklist
contributing.md).