-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic callback method detection #1469
Fix dynamic callback method detection #1469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadyvb Thanks for that fix 🙌
I've changed the target branch to develop
since we'd like to release this update as part of the upcoming 4.0.1
release. All of my comments are just about that. I'll try to address them myself, directly in GitHub, so that we're clear right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup after resolving merge conflicts with develop
directly in GH.
The Lint and Test task succeeded so I'm merging the PR to |
Fixes #1468.
Fixed the dynamic callback locating routine by removing the hyphen as a valid function name character.
Checklist
contributing.md
).Release Changelog
Release Checklist
master
branch.readme.txt
.stream.php
.Stable tag
inreadme.txt
.classes/class-plugin.php
.