Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuddyPress Connector: Check for BP dependencies before blindly assuming they're available #1517

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

dd32
Copy link
Contributor

@dd32 dd32 commented Jul 24, 2024

Fixes #1516.

Untested, this is just a visual patch from looking at the code.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Avoid potential fatal errors when using BuddyPress and Stream.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

@dd32
Copy link
Contributor Author

dd32 commented Jul 24, 2024

This PR probably avoids the fatals, but the links in network admin might be incorrect too... It might be that the links should be using get_admin_url( $blog_id, ... ) instead such as they go the correct location...

@tharsheblows
Copy link
Contributor

@delawski @dd32 This fixes the fatal errors for me --

This PR probably avoids the fatals, but the links in network admin might be incorrect too... It might be that the links should be using get_admin_url( $blog_id, ... ) instead such as they go the correct location...

I think we should merge this now and I'll open another issue to update those links.

@tharsheblows
Copy link
Contributor

Added issue for action links: #1520

@tharsheblows tharsheblows merged commit 604957e into xwp:develop Jul 24, 2024
1 check passed
@dd32
Copy link
Contributor Author

dd32 commented Jul 25, 2024

Thank you @tharsheblows!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuddyPress connector can fatal in network admin
2 participants