Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include timezone in logs for clarity #1534

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

delawski
Copy link
Contributor

Fixes #1414, #917.


#1414

Stream logs, both those displayed in WP admin and those exported to CSV or JSON, were lacking information about the timezone in which dates are represented. This PR adds the timezone information to the Stream logs.

Screenshot 2024-07-31 at 15 20 51

#917

Sometimes the "timeago" string did not fit into a single line, causing undesired text overflow issues. This PR allows the text in the date cell to break into multiple lines.

Screenshot 2024-07-31 at 15 25 42

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Enhancement: Add timezone designator to the Stream records.
  • Fix: Allow text in the date cell to break into multiple lines.

@delawski delawski added this to the 4.1.0 milestone Jul 31, 2024
@delawski delawski requested a review from tharsheblows July 31, 2024 13:38
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@tharsheblows tharsheblows merged commit 761794d into develop Jul 31, 2024
2 checks passed
@tharsheblows tharsheblows deleted the feature/1414-add-timezone branch July 31, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that times shown are in UTC
2 participants