Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display feature request notice on Settings screen #1542

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Display feature request notice on Settings screen #1542

merged 1 commit into from
Aug 5, 2024

Conversation

delawski
Copy link
Contributor

@delawski delawski commented Aug 5, 2024 •
edited
Loading

Fixes #1539

This PR adds a feature request notice on the Stream Settings screen like this:

Screenshot 2024-08-05 at 14 20 18

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • New: Display a feature request notice on the Settings screen

@delawski delawski added this to the 4.1.0 milestone Aug 5, 2024
@delawski delawski requested a review from tharsheblows August 5, 2024 12:27
@delawski delawski self-assigned this Aug 5, 2024
@tharsheblows
Copy link
Contributor

@delawski This looks good! My icon has an underline. I'm not sure if you want to forcefully remove that or not. I've approved this so left it up to you to decide!
Screenshot 2024-08-05 at 10 47 42

tharsheblows
tharsheblows approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! I hope more people will contribute issues and requests.

@delawski
Copy link
Contributor Author

delawski commented Aug 5, 2024

@delawski This looks good! My icon has an underline. I'm not sure if you want to forcefully remove that or not. I've approved this so left it up to you to decide! Screenshot 2024-08-05 at 10 47 42

Have you tried running npm run build? I'm pretty sure it's because of not having the latest stylesheet in place.

@tharsheblows
Copy link
Contributor

@delawski I did not, argh, not a good start to Monday morning!

@delawski delawski merged commit 6fb532a into develop Aug 5, 2024
2 checks passed
@delawski delawski deleted the feature/1539-leave-feedback-notice branch August 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharsheblows tharsheblows tharsheblows approved these changes

Assignees

@delawski delawski

Labels
enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Make it easier to leave feedback or a feature request
2 participants
@delawski @tharsheblows