Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 61: Fire cron event if auto-purge value is updated #208

Merged
merged 3 commits into from
Feb 4, 2014
Merged

Issue 61: Fire cron event if auto-purge value is updated #208

merged 3 commits into from
Feb 4, 2014

Conversation

powelski
Copy link

@powelski powelski commented Feb 4, 2014

Fixes #61

frankiejarrett
frankiejarrett reviewed Feb 4, 2014
View reviewed changes
includes/settings.php
$ttl_after = isset( $new_value['general_records_ttl'] ) ? (int) $new_value['general_records_ttl'] : -1;

if ( $ttl_after < $ttl_before ) {
do_action( 'stream_auto_purge' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powelski The official prefix for actions is wp_stream_

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in bc0e708

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjarrett Then it must be changed in Cron trigger itself, because it calls stream_auto_purge action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powelski Oh duh. My bad. Done in a86eb4d

@frankiejarrett
Copy link
Contributor

@powelski This is working perfectly. Just what I had in mind. Thanks! /five

frankiejarrett added a commit that referenced this pull request Feb 4, 2014
@frankiejarrett
Merge pull request #208 from x-team/issue-61
cbace1d 
Issue 61: Fire cron event if auto-purge value is updated
@frankiejarrett frankiejarrett merged commit cbace1d into develop Feb 4, 2014
@frankiejarrett frankiejarrett deleted the issue-61 branch February 4, 2014 16:09
@frankiejarrett frankiejarrett mentioned this pull request Mar 27, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fire cron event if auto-purge value is updated
2 participants
@powelski @frankiejarrett