Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 288: Minor glitch in UI when switching between Settings tabs #297

Merged
merged 6 commits into from
Mar 5, 2014

Conversation

powelski
Copy link

@powelski powelski commented Mar 5, 2014

Fix #288

@frankiejarrett
Copy link
Contributor

@powelski We really need a new method to fix this glitch?! I figured we could solve this purely with CSS. Can you explain a little more why it must be done this way?

Also please note that on Stream issues you should branch off of master and issue your PR against the develop branch. Not the other way around.

@powelski
Copy link
Author

powelski commented Mar 5, 2014

@fjarrett I made it a method, because I treat it more like a patch, which possibly won't be needed soon.

@frankiejarrett
Copy link
Contributor

@powelski It seems that just adding this to the admin.css would work:

.stream_page_wp_stream_settings .nav-tab-wrapper a:not(.nav-tab-active) {
    border-bottom: 1px solid #ccc;
}

Can you confirm?

@frankiejarrett
Copy link
Contributor

@powelski Thanks so much for this! I am less annoyed now 😸

frankiejarrett added a commit that referenced this pull request Mar 5, 2014
Issue 288: Minor glitch in UI when switching between Settings tabs
@frankiejarrett frankiejarrett merged commit 949511c into master Mar 5, 2014
@frankiejarrett frankiejarrett deleted the issue-288 branch March 5, 2014 19:13
@powelski
Copy link
Author

powelski commented Mar 5, 2014

@fjarrett You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants