Issue 293: Prevent "Auto Draft" posts from being logged #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shadyvb Please review |
| @@ -190,6 +190,11 @@ public static function callback_deleted_post( $post_id ) { | |||
| return; | |||
| } | |||
|
|
|||
| // Is auto draft? | |||
| if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) { | |||
There was a problem hiding this comment.
@powelski I don't think this alone should be the way we define auto-drafts, can't we use 'auto-draft' === $post->post_status as per https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/post.php#L473 ?
Skimming through WP code i find lots of references to the same check
frankiejarrett
added a commit
that referenced
this pull request
Mar 10, 2014
Issue 293: Prevent "Auto Draft" posts from being logged
|
@fjarrett Are you sure those dont't have |
|
@powelski According to what core is doing I thought it was |
|
+1 for checking up on core's way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293