Issue #320 - Date Interval Functionality #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the WP_Stream_Date_Interval and Carbon classes, and replaces the date from / date to fields in the Stream list table nav date with the interval fields.
| return $out; | ||
| $date_predefined = isset( $_GET['date_predefined'] ) ? esc_attr( $_GET['date_predefined'] ) : ''; | ||
| $date_from = isset( $_GET['date_from'] ) ? esc_attr( $_GET['date_from'] ) : ''; | ||
| $date_to = isset( $_GET['date_to'] ) ? esc_attr( $_GET['date_to'] ) : ''; |
There was a problem hiding this comment.
@lukecarbis We can use the new wp_stream_filter_input() family here instead.
Instead of checking isset on $_GET.
From stream-predefined-intervals to wp_stream_predefined_date_intervals.
frankiejarrett
added a commit
that referenced
this pull request
Mar 12, 2014
Issue #320 - Date Interval Functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #320.
This pull request adds the WP_Stream_Date_Interval and Carbon classes so that we can leverage the Reports date interval class in core (and other plugins).
It also replaces the Stream list table nav date from / to fields with interval fields.