Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 356 Add live updates to dashboard widget #383

Merged
merged 16 commits into from
Apr 2, 2014
Merged

Conversation

johnregan3
Copy link
Contributor

Live Updates for Dashboard Widget.

  • "Enable live updates" checkbox
  • Default setting to true on install
  • Configure heartbeat response
  • One method to fire on heartbeat_recieved to handle Dashboard and Stream Page requests (DRY)
  • One method to generate list items for dashboard widget, whether initial page load or heartbeat
  • JS to handle updating the Dashboard
  • When new items are added, remove correct number to keep records_per_page
  • Only display updates on first page of results
  • Highlighting/Fadeout of new items

Fixes #356

@fjarrett

@frankiejarrett
Copy link
Contributor

@johnregan3

  1. When I checkout the branch the option is not checked by default. Since no DB value exists to explicitly turn it off, it should be checked and turned on by default.
  2. I think we should be using similar logic to what was used in the list table with the live update values being on and off strings.

screen shot 2014-04-02 at 9 39 01 am

@johnregan3
Copy link
Contributor Author

@fjarrett The option is now enabled by default, using similar logic to the Stream Live Update checkbox. Tested by using delete_option on page load, and "Enabled" is the default state.

@frankiejarrett
Copy link
Contributor

@johnregan3 Nice work! Now please merge master into this branch and resolve any conflicts. And lastly, please remember to issue against the develop branch next time.

@johnregan3
Copy link
Contributor Author

@fjarrett Sorry, man. I get mixed up between projects. I'll get it fixed.

frankiejarrett added a commit that referenced this pull request Apr 2, 2014
Issue 356 Add live updates to dashboard widget
@frankiejarrett frankiejarrett merged commit 0de66c5 into master Apr 2, 2014
@frankiejarrett frankiejarrett deleted the issue-356 branch April 2, 2014 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants