Issue 65: Enable Stream on multisite / network installs #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added check for is_multisite() to db $prefix definition to use base_prefix - Updated install $sql to include blog_id column - Added update function to run install() and alter the column order - Added site_id and blog_id values to query defaults - Run install check method on plugins_loaded. plugin_activation_hook doesn't run when updating
- Added blog_id and site_id to fields array - Added blog_id and site_id values to $recordarr - Removed debugging statement from query
- Add stream page to network admin screen if if plugin is network activated - Add WP_STREAM_PLUGIN const to use for checking if plugin is network activated
- Replaced all occurrences of admin_url() with network_admin_url() if is_network_admin() returns true - Updated query args for blog_id filter
- Added all actions to be tracked - Created empty callback function for each action
…fore adding connector items
- Added check for is_network_admin before defaulting the blog_id logged as 1 - Added function to the list table to generate a blog object for actions done in network admin
- Will allow extensions and future features to set blog_id without relying on get_current_blog_id() or is_network_admin()
Conflicts: stream.php
- Added settings API wrapper for saving network wide settings - Added filter to get_fields method to allow settings to be extended - Added function to filter stream get settings to load correct values on network admin settings page
- Add select field to network options screen to choose site to change settings for - Removed redundant code that called admin_notices from network admin screen - Added public static variable $disable_site_admin, gets set to true when network option checked to dis allow access to individual site admin screens - Added html output for select in settings render method
Conflicts: includes/admin.php includes/db-actions.php includes/install.php includes/list-table.php includes/settings.php
Conflicts: includes/admin.php includes/settings.php
|
These are the tests I've run on this branch: http://pastebin.com/3LXyFqDP Please feel free to suggest any additional testing that may be required. Waiting for a reply at #396 (comment) before having a crack at that last checkbox. |
|
@lukecarbis It'd be extra cool if those tests were carried out in phpunit format, specially for such significant feature.. not sure if there is enough time for it thought. |
|
@lukecarbis I decided to add Stream to the Network admin bar. Done in 4be02d2
|
Conflicts: includes/db.php
The Network Admin has the id of zero. We should be able to ask for results from this id.
Conflicts: includes/db-updates.php includes/install.php
If Stream is running on a single site install that switches to multisite later, this will ensure records remain in the main site's Stream
Conflicts: includes/admin.php
Conflicts: includes/admin.php includes/db-updates.php
frankiejarrett
added a commit
that referenced
this pull request
Apr 22, 2014
Issue 65: Enable Stream on multisite / network installs
|
/five @c3mdigital @powelski @lukecarbis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #154 for additional discussion. Resolves #65
type=stream) for all sites