-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 389: Save additional author meta as Stream meta #413
Conversation
@lukecarbis Please put the update routine for this inside the #379 branch. At the top of: https://github.com/x-team/wp-stream/blob/issue-379/includes/db-updates.php |
@fjarrett Ready for your review. |
$author_role = $wp_roles->role_names[ $user->roles[0] ]; | ||
} else { | ||
$author_role = $item->author_role; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukecarbis Logic looks great. Maybe add some inline comments to explain what each fallback is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@lukecarbis Don't forget to add the column during table creation on new installs. https://github.com/x-team/wp-stream/blob/issue-389/includes/install.php#L50 |
@fjarrett I put it here: 5a9d80c#diff-0e76810e485377b380ecabaec99134abR273 |
@lukecarbis Ah, my bad. |
Issue 389: Save additional author meta as Stream meta
Adds author meta as per #389 .