Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 389: Save additional author meta as Stream meta #413

Merged
merged 11 commits into from
Apr 17, 2014

Conversation

lukecarbis
Copy link
Contributor

Adds author meta as per #389 .

@frankiejarrett
Copy link
Contributor

@lukecarbis Please put the update routine for this inside the #379 branch.

At the top of: https://github.com/x-team/wp-stream/blob/issue-379/includes/db-updates.php

@lukecarbis
Copy link
Contributor Author

@fjarrett Ready for your review.

$author_role = $wp_roles->role_names[ $user->roles[0] ];
} else {
$author_role = $item->author_role;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukecarbis Logic looks great. Maybe add some inline comments to explain what each fallback is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@frankiejarrett
Copy link
Contributor

@lukecarbis Don't forget to add the column during table creation on new installs.

https://github.com/x-team/wp-stream/blob/issue-389/includes/install.php#L50

@lukecarbis
Copy link
Contributor Author

@frankiejarrett
Copy link
Contributor

@lukecarbis Ah, my bad.

frankiejarrett added a commit that referenced this pull request Apr 17, 2014
Issue 389: Save additional author meta as Stream meta
@frankiejarrett frankiejarrett merged commit 82d5fc2 into develop Apr 17, 2014
@frankiejarrett frankiejarrett deleted the issue-389 branch April 17, 2014 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants