Issue 487: Add ignored comment types to comments connector #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecarbis
changed the title
added 3 commits
May 2, 2014 08:34
b88ad0b Merge pull request #35 from x-team/develop 2ad10ee Add sample .ci-env.sh to readme ffbe9ea Add built-in VVV support to pre-commit hook 98f6174 Fix PHPCS issues new from WordPress:core-extra 54f710a Use same WP_VERSION in .travis.yml as WP-CLI's template d8e6928 Fetch and use latest install-wp-tests.sh from wp-cli GitHub repo d6c29fc Use .ci-env.sh (nee .travis.before_script.sh) in pre-commit hook 3344571 Fix .travis.yml syntax error fb5d1cc Allow PHPCS and WPCS to pull from different locations 4529787 Improve URL regex for readme builder dab2ab1 Merge commit '025f3510009d530e4313d4c94a714e555f467288' e73f2d6 Updating readme parser 02cb910 Post connector tests ce084cf Append branch param to Travis CI status image URL 91dd266 Changelog for 0.3 release git-subtree-dir: bin git-subtree-split: b88ad0bfa62d87c050b14984a4e01ca3b4f06228
|
This can be tested using WooCommerce and https://github.com/x-team/wp-stream-connector-woocommerce/. WooCommerce adds 'notes' to an order when the status changes, using comments. The Stream WooCommerce Connector tries to exclude these from appearing in Stream under the Comments connector, in favour of handling them differently. So, if you're on this branch, you shouldn't see any |
|
@lukecarbis Nice work. I went ahead and also applied this to the duplicated comment method as well, since it might be desired for another purpose other than WooCommerce. |
frankiejarrett
added a commit
that referenced
this pull request
May 9, 2014
Issue 487: Add ignored comment types to comments connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #487