Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filterable frontend indicator method #509

Merged
merged 2 commits into from
May 6, 2014
Merged

Add filterable frontend indicator method #509

merged 2 commits into from
May 6, 2014

Conversation

frankiejarrett
Copy link
Contributor

Resolves #507

screen shot 2014-05-06 at 3 37 29 pm

Can be easily removed, if desired, like so:

add_filter( 'wp_stream_frontend_indicator', function() { return false; } );

@lukecarbis Please review

@lukecarbis
Copy link
Contributor

Code is flawless (as far as I can tell). Tested and works.

lukecarbis added a commit that referenced this pull request May 6, 2014
@lukecarbis
Merge pull request #509 from x-team/issue-507
b5f1361 
Add filterable frontend indicator method
@lukecarbis lukecarbis merged commit b5f1361 into develop May 6, 2014
@lukecarbis lukecarbis deleted the issue-507 branch May 6, 2014 22:32
@lukecarbis lukecarbis mentioned this pull request May 6, 2014
Closed
@frankiejarrett
Copy link
Contributor Author

@lukecarbis Thank you very much! /five

shadyvb
shadyvb reviewed May 8, 2014
View reviewed changes
stream.php
echo sprintf( "<!-- %s -->\n", esc_html( $comment ) ); // xss ok
}

return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjarrett I think we can omit this one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadyvb Yeah, it's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadyvb Done in 650df12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce lightweight frontend indicator for sites using Stream
3 participants
@frankiejarrett @lukecarbis @shadyvb