Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change user-login callback to capture custom authentication schemes #513

Merged
merged 1 commit into from
May 9, 2014

Conversation

shadyvb
Copy link
Contributor

@shadyvb shadyvb commented May 7, 2014

Fix #434, related to #501

@frankiejarrett
Copy link
Contributor

@shadyvb Running with the assumption that we can abstract the storage backend, how would this affect VIP sites using Stream?

Just looking at their docs about server-side cookie handling and SSO through the WordPress.com network: http://vip.wordpress.com/documentation/wordpress-com-vs-wordpress-org/#registering-users

/cc @westonruter

@westonruter
Copy link
Contributor

I don't believe there are any SSO schemes available on WordPress.com, even for VIP. Though I did find this: http://vip.wordpress.com/documentation/faux-single-sign-on/

@shadyvb
Copy link
Contributor Author

shadyvb commented May 8, 2014

@fjarrett This addressing the default behavior of WP, unless they're doing some weird stuff on authenticate filter, this should be working. So we'll have to wait and see.
The advantage to this, is that is works on the final stage of any user authentication, whatever way you use to authenticate, you'll always need to set a cookie, that's where we currently hook ( in this PR ).

@shadyvb
Copy link
Contributor Author

shadyvb commented May 8, 2014

Reviewing the link @westonruter mentioned, that SSO method is using some front-end cookie handling, so i don't think we can handle that anyway.

@frankiejarrett
Copy link
Contributor

Tested using Clef and Stream recorded the user login perfectly.

frankiejarrett added a commit that referenced this pull request May 9, 2014
Change user-login callback to capture custom authentication schemes
@frankiejarrett frankiejarrett merged commit 1748431 into develop May 9, 2014
@frankiejarrett frankiejarrett deleted the issue-434 branch May 9, 2014 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom usage of wp_signon does not track user logins correctly
3 participants