Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Stream connectors early on priority 0 of init hook #514

Merged
merged 3 commits into from
May 14, 2014

Conversation

shadyvb
Copy link
Contributor

@shadyvb shadyvb commented May 7, 2014

Fixes #501 , but would probably need some good testing to make sure everything else works, specially extensions, as this might make it difficult to hook/modify some behavior of
connectors.

/cc @fjarrett @lukecarbis

@frankiejarrett
Copy link
Contributor

@shadyvb This does not appear to be working for me.

The only records that appear are for Logout and there are no records for Login.

screen shot 2014-05-09 at 4 57 58 pm

@shadyvb
Copy link
Contributor Author

shadyvb commented May 10, 2014

@fjarrett Works after merging develop with the custom authentication tracking fix.

@frankiejarrett
Copy link
Contributor

I've tested this again and it's working great. Notifications are also still working fine and the Reports also look good too.

screen shot 2014-05-10 at 10 14 34 am

/cc @lukecarbis @Japh please do some sanity checks on this one for me.

@lukecarbis
Copy link
Contributor

I've tested and everything works for me. I focused particularly on Extensions (connecting, installing, activating, etc.) and Exporter.

frankiejarrett added a commit that referenced this pull request May 14, 2014
Register Stream connectors early on priority 0 of init hook
@frankiejarrett frankiejarrett merged commit 794c8a9 into develop May 14, 2014
@frankiejarrett frankiejarrett deleted the issue-first-in-line branch May 14, 2014 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching user is incorrectly tracked
3 participants