Do not serialize already serialized values #515
Conversation
|
@westonruter Please review. |
| return $current_version; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
@shadyvb from the author_meta streammeta record shared by @krogsgard in #477, the underlying DB value is not double-serialized. Also, maybe_serialize() explicitly prevents double-serialization of strings: https://github.com/x-team/wordpress-develop/blob/cd356b6404b5a770cf69f81f80efd6eb046e6c57/src/wp-includes/functions.php#L354-L372
There was a problem hiding this comment.
I am so wrong. It is getting double-serialized, as @shady pointed out: s:192:"a:5:{s:10:"user_. It's a serialized string containing the serialized array.
|
How widespread is issue #477? If this is only affecting a minority of users, would we consider ignoring existing data, so that we don't need an update routine? We could provide the fix via support channels to those who need it. That way we're not taxing everyone's database with a big update routine, even if they might not need it. Of course, if this is a widespread problem, that won't work. In my experience, functions like |
| $row->meta_value = maybe_unserialize( $meta_value ); | ||
| } | ||
| // update_metadata will serialize it back | ||
| wp_stream_update_meta( $row->record_id, 'author_meta', $row->meta_value ); |
There was a problem hiding this comment.
Would adding another is_serialized check help to avoid updating every meta record in the db?
if ( is_serialized( $row->meta_value ) ) {
$row->meta_value = @unserialize( $row->meta_value );
if ( is_serialized( $row->meta_value ) ) {
$row->meta_value = @unserialize( $meta_value );
}
// update_metadata will serialize it back
wp_stream_update_meta( $row->record_id, 'author_meta', $row->meta_value );
}Reference: wp-includes/functions.php:252-256
There was a problem hiding this comment.
@lukecarbis Yea, that makes perfect sense.
|
@lukecarbis After considering this for a while, I do think an update routine is necessary because this is fixing malformed data caused by a code bug. If this were a case of adding new record meta or something we would not do any routine, saying that records from now on would have the new data, but this is simply not the case here. Furthermore, we're only going to alter existing records which contain the malformed data, and that makes sense to me. /cc @shadyvb @westonruter |
| set_time_limit( 0 ); // This will probably take abit of time! | ||
| global $wpdb; | ||
| // Get all author_meta meta values, serialize them properly | ||
| $sql = "SELECT record_id, meta_value WHERE meta_key = 'author_meta'"; |
There was a problem hiding this comment.
@shadyvb we could speed this up a huge amount, and skip entries that aren't already malformed, by doing a LIKE query like so:
$sql = "SELECT record_id, meta_value WHERE meta_key = 'author_meta' AND meta_value LIKE 's:%'";Or a SUBSTRING(meta_value…) could be used.
There was a problem hiding this comment.
@westonruter Added in 4164e81, removed the redundant check ( since they'll all be double serialized )
/five!
|
Here's an example of the It hasn't changed. This is on multisite. |
| global $wpdb; | ||
|
|
||
| // Get only the author_meta values that are double-serialized | ||
| $sql = "SELECT record_id, meta_value WHERE meta_key = 'author_meta' AND meta_value LIKE 's:%'"; |
There was a problem hiding this comment.
@shadyvb @westonruter Where in this statement is the table name wp_stream_meta indicated?
There was a problem hiding this comment.
I think it should be:
$prefix = WP_Stream_Install::$table_prefix;
$sql = "SELECT record_id, meta_value FROM {$prefix}stream_meta WHERE meta_key = 'author_meta' AND meta_value LIKE 's:%'";
|
Looks good. Worked for me on multisite. Tried upgrading from 1.4.3, too. /five Author meta is being saved properly now. |
Do not serialize already serialized values
Related to #477 , however will not fix existing data, yet