Use default textdomain where possible #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/five @fjarrett . Here's what it looks like with an Italian install (there are no language files for Italian in Stream).
Note that words like Installer, Widget or Spreadsheet aren't translated in WordPress, either (or they are, and they're just the same as in English). Happy to merge if you are. |
|
As you pointed out in our chat, words like Spreadsheet and Installer aren't using the |
|
@lukecarbis Hoping you can approve this to be merged today. |
lukecarbis
added a commit
that referenced
this pull request
May 20, 2014
Use default textdomain where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #534
I've gone through all the connectors and includes to use the
defaulttextdomain wherever possible instead of always usingstream. I did this by checking a core language pack PO file and ensuring the strings there were identical to ours.@lukecarbis Please review